Allow running tests via CMake build script #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 56.19% 56.18% -0.01%
==========================================
Files 54 54
Lines 6357 6356 -1
==========================================
- Hits 3572 3571 -1
Misses 2785 2785
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This looks like a good direction. I think separate script files for the checks like yamllint and perl style are a good idea but I am worried about the additional complexity of tools/invoke-tests. In principle we should just be able to call prove -l -r without anything additional and that should work to run all the tests. I don't even know if there is any reason why we still need to explicitly list all the tests within os-autoinst. I know that originally that was necessary but over the years we have actually fixed a lot of problems so maybe we can just go with an approach similar to what we do in openQA and not need an explicit list of test modules anymore. In the spec file we can then simply delete the test files directly instead of only deleting the reference in a test list.
EDIT: I just tried out PERL5LIB=$PWD:$PERL5LIB prove -l -r and that seems to do what it should for all test modules
|
See #1480 for my proposal to get rid of the hardcoded test list first. After that we could take a look what would still be needed from |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
…e-tests * Use getopt to parse arguments * Don't rely on the script being executed within the source directory
* Improve targets for coverage computation so it is ensured that everything is built correctly * Add target to reset gathered coverage data * Enable verbose CTest output by default (see comment for reasoning)
Martchus
force-pushed
the
cmake
branch
2 times, most recently
from
c668793
to
49d450a
Compare
|
(I've restarted the Travis job after it succeeded but apparently could not report that.) |
No description provided.